Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UA] Make reindex error handling more robust #33060

Merged
merged 1 commit into from Mar 13, 2019

Conversation

joshdover
Copy link
Member

@joshdover joshdover commented Mar 12, 2019

Summary

Closes #32665

The error messages for the Task API is not stable and different types of errors can show up in different parts of the response. This change includes the entire task response in the error message so that wherever the error message is, the user can find it.

Steps to reproduce

Index data without _source:

PUT logs
{
  "mappings": {
    "_source": {
      "enabled": false
    }
  }
}

PUT logs/_doc/1
{
  "requests": {
    "count": 10,
    "foo": "bar" 
  },
  "meta": {
    "name": "Some metric",
    "description": "Some metric description", 
    "other": {
      "foo": "one", 
      "baz": "two" 
    }
  }
}

Start a reindex via the API:

$ curl localhost:5601/api/upgrade_assistant/reindex/logs -XPOST -H 'kbn-xsrf: xxx'

Wait for it to fail (should see stacktrace in ES logs) and then check the errorMessage key of the reindex status API:

$ curl localhost:5601/api/upgrade_assistant/reindex/logs

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@joshdover joshdover changed the title [UA] Make reindex error handle more robust [UA] Make reindex error handling more robust Mar 12, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tylersmalley
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tylersmalley tylersmalley merged commit 3c60eb1 into elastic:master Mar 13, 2019
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Mar 13, 2019
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Mar 13, 2019
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Mar 13, 2019
@joshdover joshdover added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Upgrade Assistant non-issue Indicates to automation that a pull request should not appear in the release notes Team:Operations Team label for Operations Team v6.7.1 v7.0.1 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants