New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UA] Make reindex error handling more robust #33060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-operations |
joshdover
changed the title
[UA] Make reindex error handle more robust
[UA] Make reindex error handling more robust
Mar 12, 2019
💚 Build Succeeded |
joshdover
force-pushed
the
ua-handle-more-errors
branch
from
March 13, 2019 04:05
d0d227c
to
5cc063f
Compare
💔 Build Failed |
retest |
tylersmalley
approved these changes
Mar 13, 2019
💚 Build Succeeded |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 13, 2019
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 13, 2019
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 13, 2019
tylersmalley
added a commit
that referenced
this pull request
Mar 13, 2019
tylersmalley
added a commit
that referenced
this pull request
Mar 13, 2019
tylersmalley
added a commit
that referenced
this pull request
Mar 13, 2019
joshdover
added
the
non-issue
Indicates to automation that a pull request should not appear in the release notes
label
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Upgrade Assistant
non-issue
Indicates to automation that a pull request should not appear in the release notes
Team:Operations
Team label for Operations Team
v6.7.1
v7.0.1
v7.2.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #32665
The error messages for the Task API is not stable and different types of errors can show up in different parts of the response. This change includes the entire task response in the error message so that wherever the error message is, the user can find it.
Steps to reproduce
Index data without
_source
:Start a reindex via the API:
Wait for it to fail (should see stacktrace in ES logs) and then check the
errorMessage
key of the reindex status API: